[Marble-devel] Review Request 114901: Show colors in setting page of positionmaker plugin

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114901/#review46998
-----------------------------------------------------------


First of all: A warm welcome to Marble development! And thanks a lot for your patch! It's always great to see people getting involved to fix these small details that give Marble the finished look that it deserves.
The usage of StyleSheets with Qt has always been discouraged for "serious" stuff (like Marble ;) ). The StyleSheet parts of the Qt framework have always been shunned as quirky and unreliable. This is partially due to the high-levelness of the concept as well as due the clash with other parts of the Qt framework.

Could you rework your patch to use QPalette to fix the issue? Thanks a lot and keep on rocking!  

- Torsten Rahn


On Jan. 7, 2014, 7:13 p.m., Simon Danner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114901/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2014, 7:13 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The settings display of the positionmarker plugin doesn't show the current selected colors on the buttons, wich i expected. This patch fixes it.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/positionmarker/PositionMarker.cpp 45f20c5 
> 
> Diff: https://git.reviewboard.kde.org/r/114901/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Simon Danner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140107/0639845d/attachment.html>