[Marble-devel] Review Request 114868: kml2pack tool introduced

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Sun Jan 5 00:03:32 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114868/
-----------------------------------------------------------

Review request for Marble, Dennis Nienhüser and Torsten Rahn.


Repository: marble


Description
-------

According to Google Code-in task (http://www.google-melange.com/gci/task/view/google/gci2013/6456028812017664):

kml2pack added as a Marble tool and works properly, which may be proved by it's debug output:
=====
parallels at ubuntu:~/Gci/marble/build/tools/kml2pack$ ./kml2pack germany.kml germany.pack
Polygon is getting packed 
IconStyle is getting packed 1.1 
IconStyle is getting packed 1.3
=====
Looking through germany.kml will show you that there is a Polygon tag and two IconStyle tags.

These debug calls, injected into pack() of corresponding methods are removed in the patch.


Diffs
-----

  tools/CMakeLists.txt 48a1b36 
  tools/kml2pack/CMakeLists.txt PRE-CREATION 
  tools/kml2pack/kml2pack.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/114868/diff/


Testing
-------

Manual testing


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140105/8606e450/attachment-0001.html>


More information about the Marble-devel mailing list