[Marble-devel] Review Request 114720: [GCI] Factor constellation names out of star plugin. (2)

[Mihail Ivchenko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114720/
-----------------------------------------------------------

(Updated Jan. 5, 2014, 1:09 a.m.)


Status
------

This change has been discarded.


Review request for Marble.


Repository: marble


Description
-------

Factor constellation names out of star plugin.
That's second way to do that.
GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5233734269796352

First way: https://git.reviewboard.kde.org/r/114719

That's way takes about 11-12 ms for creating object (first run) and 5ms (other)


Diffs
-----

  src/plugins/render/stars/CMakeLists.txt 4bdc4f2 
  src/plugins/render/stars/StarsNames.h PRE-CREATION 
  src/plugins/render/stars/StarsNames.cpp PRE-CREATION 
  src/plugins/render/stars/StarsPlugin.h 662ab1a 
  src/plugins/render/stars/StarsPlugin.cpp 4bed657 

Diff: https://git.reviewboard.kde.org/r/114720/diff/


Testing
-------


Thanks,

Mihail Ivchenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140104/ed533274/attachment.html>