[Marble-devel] Review Request 114854: Support worldwind URIs in Marble

Dennis Nienhüser earthwings at gentoo.org
Sat Jan 4 16:47:46 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114854/#review46797
-----------------------------------------------------------



src/apps/marble-kde/kdemain.cpp
<https://git.reviewboard.kde.org/r/114854/#comment33411>

    I'd check isEmpty() here as well just like in the Qt version. The parser should handle that case fine as well, but there's no need to create it for that (isEmpty will be true most times)



src/apps/marble-ui/ControlView.cpp
<https://git.reviewboard.kde.org/r/114854/#comment33412>

    Please replace all name() calls of Planet with calls to id(). name() is the (possibly translated) name, id() is what you pass in the constructor of Planet.
    



src/lib/marble/GeoUriParser.cpp
<https://git.reviewboard.kde.org/r/114854/#comment33413>

    the Marble internal id is "earth"



src/lib/marble/GeoUriParser.cpp
<https://git.reviewboard.kde.org/r/114854/#comment33414>

    the Marble internal id is "earth"


- Dennis Nienhüser


On Jan. 4, 2014, 4:34 p.m., Levente Kurusa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114854/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2014, 4:34 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This is a GCI task: https://www.google-melange.com/gci/task/view/google/gci2013/5784750857912320
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-kde/CMakeLists.txt a39bf51 
>   src/apps/marble-kde/kdemain.cpp 84c43d3 
>   src/apps/marble-kde/marble_worldwind.desktop PRE-CREATION 
>   src/apps/marble-qt/qtmain.cpp 26e1a03 
>   src/apps/marble-ui/ControlView.h 322708b 
>   src/apps/marble-ui/ControlView.cpp fc9022f 
>   src/lib/marble/GeoUriParser.h fc0a6ba 
>   src/lib/marble/GeoUriParser.cpp de56e90 
>   tests/GeoUriParserTest.cpp 44bd7de 
> 
> Diff: https://git.reviewboard.kde.org/r/114854/diff/
> 
> 
> Testing
> -------
> 
> Attached unit tests pass.
> 
> 
> File Attachments
> ----------------
> 
> Konq opening worldwind:// uri
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/04/16b93c0e-ca78-4ec1-84e1-cdcb06af7394__geouriworking2.png
> 
> 
> Thanks,
> 
> Levente Kurusa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140104/7a1087e4/attachment.html>


More information about the Marble-devel mailing list