[Marble-devel] Review Request 114819: Open Geo URIs with Marble

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114819/#review46705
-----------------------------------------------------------



src/apps/marble-kde/kdemain.cpp
<https://git.reviewboard.kde.org/r/114819/#comment33342>

    bracket style:
    
    if (...) {
    
    }



src/apps/marble-kde/marble_geo.desktop
<https://git.reviewboard.kde.org/r/114819/#comment33344>

    NoDispLAy



src/apps/marble-qt/qtmain.cpp
<https://git.reviewboard.kde.org/r/114819/#comment33345>

    ..... {



src/lib/marble/GeoUriParser.h
<https://git.reviewboard.kde.org/r/114819/#comment33346>

    Maybe this should have a reference to the Wikipedia article of GeoURIs for explanation - or to the standard itself



src/lib/marble/GeoUriParser.cpp
<https://git.reviewboard.kde.org/r/114819/#comment33347>

    Should this really be double or qreal?


- Torsten Rahn


On Jan. 3, 2014, 6:26 p.m., Levente Kurusa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114819/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 6:26 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This is a GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5847453085466624
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-kde/CMakeLists.txt 4817a15 
>   src/apps/marble-kde/kdemain.cpp 1b4733d 
>   src/apps/marble-kde/marble_geo.desktop PRE-CREATION 
>   src/apps/marble-kde/marble_part.desktop 29aaad6 
>   src/apps/marble-qt/qtmain.cpp 2f593bb 
>   src/lib/marble/CMakeLists.txt 15a02b6 
>   src/lib/marble/GeoUriParser.h PRE-CREATION 
>   src/lib/marble/GeoUriParser.cpp PRE-CREATION 
>   tests/CMakeLists.txt 6531fd4 
>   tests/GeoUriParserTest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/114819/diff/
> 
> 
> Testing
> -------
> 
> Created four unit tests, they are mostly testing the regexp, they all pass.
> 
> 
> File Attachments
> ----------------
> 
> GeoURI is working!
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/03/713ecc80-6cf7-42ff-819d-9b1892540cf5__geouriworking.png
> 
> 
> Thanks,
> 
> Levente Kurusa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140103/3227fc22/attachment.html>