[Marble-devel] Review Request 114819: Open Geo URIs with Marble

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114819/#review46693
-----------------------------------------------------------



src/lib/marble/GeoUriParser.h
<https://git.reviewboard.kde.org/r/114819/#comment33335>

    QString(). Otherwise krazy [0] will bitch at us ;-)
    
    [0] http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/marble/index.html
    



src/lib/marble/GeoUriParser.cpp
<https://git.reviewboard.kde.org/r/114819/#comment33336>

    m_coordinates() is perfectly fine.



src/lib/marble/GeoUriParser.cpp
<https://git.reviewboard.kde.org/r/114819/#comment33337>

    GeoDataCoordinates() is perfectly fine.



src/lib/marble/GeoUriParser.cpp
<https://git.reviewboard.kde.org/r/114819/#comment33338>

    are *not*, I guess?
    Should be a mDebug only, nothing serious.
    


- Dennis Nienhüser


On Jan. 3, 2014, 2:34 p.m., Levente Kurusa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114819/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 2:34 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This is a GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5847453085466624
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-kde/CMakeLists.txt 4817a15 
>   src/apps/marble-kde/kdemain.cpp 1b4733d 
>   src/apps/marble-kde/marble.protocol PRE-CREATION 
>   src/apps/marble-qt/qtmain.cpp 2f593bb 
>   src/lib/marble/CMakeLists.txt 15a02b6 
>   src/lib/marble/GeoUriParser.h PRE-CREATION 
>   src/lib/marble/GeoUriParser.cpp PRE-CREATION 
>   tests/CMakeLists.txt 6531fd4 
>   tests/GeoUriParserTest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/114819/diff/
> 
> 
> Testing
> -------
> 
> Created four unit tests, they are mostly testing the regexp, they all pass.
> 
> 
> Thanks,
> 
> Levente Kurusa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140103/095740fc/attachment.html>