[Marble-devel] Review Request 114782: Refactoring planet rendering code in Stars Plugin

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Wed Jan 1 17:07:51 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114782/
-----------------------------------------------------------

Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.


Summary (updated)
-----------------

Refactoring planet rendering code in Stars Plugin


Repository: marble


Description (updated)
-------

According to Google Code-in 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5777453708476416):

* Planet rendering moved to renderPlanet(..)
* Planet rendering flags merged into QMap<QString, bool> m_renderPlanet (<planet name, available?>)
* Settings loading/saving, reading/writing adjusted to serialize/unser. m_renderPlanet


Diffs
-----

  src/plugins/render/stars/StarsPlugin.h a027ef3 
  src/plugins/render/stars/StarsPlugin.cpp 89fd1a8 

Diff: https://git.reviewboard.kde.org/r/114782/diff/


Testing (updated)
-------

Compared to KStars, GUI testing


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140101/bc669893/attachment.html>


More information about the Marble-devel mailing list