[Marble-devel] Review Request 116059: Patch for BUG: 331467 (KmlPhotoOverlayWriter)

[Cruceru Calin-Cristian]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116059/
-----------------------------------------------------------

(Updated Feb. 28, 2014, 9:29 p.m.)


Review request for Marble.


Changes
-------

Included in the last patch the modification to Point writing.


Bugs: 331467
    http://bugs.kde.org/show_bug.cgi?id=331467


Repository: marble


Description
-------

Extend KmlPhotoOverlayWriter.cpp to also write the following elements (and their children): - rotation - ViewVolume - ImagePyramid - shape 

I fail the test with tests/TestGeoDataWriter so I'm waiting for review with what I'm doing wrong.


Diffs (updated)
-----

  src/lib/marble/geodata/writers/kml/KmlPhotoOverlayWriter.cpp 5903654 
  tests/CMakeLists.txt 198c6c3 
  tests/TestGeoDataWriter.cpp 45e6321 
  tests/TestPhotoOverlay.cpp f4d8b32 
  tests/data/PhotoOverlayAsRoot.kml PRE-CREATION 
  tests/data/PhotoOverlayInFolder.kml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116059/diff/


Testing
-------


File Attachments
----------------

The testing file
  https://git.reviewboard.kde.org/media/uploaded/files/2014/02/25/091ac6a9-8b67-434a-a678-d15a7d87f4c5__0002-Update.patch


Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140228/e61e2fc7/attachment.html>