[Marble-devel] Review Request 116074: Implement equality comparison of GeoDataAccuracy and GeoDataAlias

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116074/#review50908
-----------------------------------------------------------


This review has been submitted with commit 1185ae26133646d14582e6c82cf458c752feb5be by Dennis Nienhüser on behalf of Cruceru Calin-Cristian to branch master.

- Commit Hook


On Feb. 26, 2014, 6:30 a.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116074/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 6:30 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 331470
>     http://bugs.kde.org/show_bug.cgi?id=331470
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added two methods bool operator==( const GeoDataAlias &other ) const; bool operator!=( const GeoDataAlias &other ) const; to GeoDataAlias which implement equality comparision.
> Added a new unit test in tests/ called TestEquality.cpp which creates different GeoDataAlias instances and compares them.
> Extended GeoDataAccurary by adding a new operator bool operator!=( const GeoDataAccuracy &other ) const;
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataAccuracy.h 0314e9d 
>   src/lib/marble/geodata/data/GeoDataAccuracy.cpp 891a4a2 
>   src/lib/marble/geodata/data/GeoDataAlias.h 9ffcb39 
>   src/lib/marble/geodata/data/GeoDataAlias.cpp 9cf95ce 
>   tests/CMakeLists.txt a6dad0c 
>   tests/TestEquality.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116074/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140226/06f5f13f/attachment.html>