[Marble-devel] Review Request 115938: Modified patch for bug 331369 - Code style fixes in QtMainWindow

Dennis Nienhüser earthwings at gentoo.org
Tue Feb 25 18:05:05 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115938/#review50857
-----------------------------------------------------------


Setting the branch here to master is not enough. The code needs to be changed and the diff updated. Can you look into that, please?


- Dennis Nienhüser


On Feb. 24, 2014, 9:24 p.m., Savita Seetaraman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115938/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 9:24 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This is the patch for bug : 331369. It fixes code styles in src/apps/marble-qt/QtMainWindow.h and src/apps/marble-qt/QtMainWindow.cpp . 
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-qt/QtMainWindow.h 80ae250 
>   src/apps/marble-qt/QtMainWindow.cpp 750650a 
> 
> Diff: https://git.reviewboard.kde.org/r/115938/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Savita Seetaraman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140225/445b8e37/attachment.html>


More information about the Marble-devel mailing list