[Marble-devel] Review Request 121769: Replacing EARTH_RADIUS with Planet class where possible
Illya Kovalevskyy
illya.kovalevskyy at gmail.com
Tue Dec 30 20:30:34 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121769/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 10:30 p.m.)
Review request for Marble and Torsten Rahn.
Repository: marble
Description (updated)
-------
This patch gets rid of EARTH_RADIUS where it's possible, replacing it with Planet class approach and fixes using "R" variable in codebase.
Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5308478797119488
Diffs (updated)
-----
src/apps/marble-ui/ControlView.cpp 64c6b85
src/lib/marble/PositionTracking.h 0e7f951
src/lib/marble/routing/RoutingModel.cpp a90f248
src/lib/marble/routing/RoutingWidget.cpp b0171aa
src/plugins/declarative/Bookmarks.cpp 4fa2316
src/plugins/declarative/Navigation.cpp 575179b
src/plugins/render/measure/MeasureToolPlugin.cpp b292c23
src/plugins/render/positionmarker/PositionMarker.h cf24599
src/plugins/render/positionmarker/PositionMarker.cpp 45f20c5
src/plugins/render/routing/RoutingPlugin.cpp 09aec31
src/plugins/render/satellites/SatellitesTLEItem.cpp 57adefe
Diff: https://git.reviewboard.kde.org/r/121769/diff/
Testing (updated)
-------
Unit tests, visual testing
Thanks,
Illya Kovalevskyy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141230/b8fb6bb9/attachment-0001.html>
More information about the Marble-devel
mailing list