[Marble-devel] Review Request 121751: [GCI] Change ToolButtons for Tour UI
Torsten Rahn
tackat at kde.org
Tue Dec 30 16:12:44 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121751/#review72785
-----------------------------------------------------------
Ship it!
Ship It!
- Torsten Rahn
On Dez. 30, 2014, 12:53 nachm., Mihail Ivchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121751/
> -----------------------------------------------------------
>
> (Updated Dez. 30, 2014, 12:53 nachm.)
>
>
> Review request for Marble.
>
>
> Repository: marble
>
>
> Description
> -------
>
> GCI task: https://www.google-melange.com/gci/task/view/google/gci2014/5281798460276736
> Add "DropDown button" for adding tour primitive.
> After playing tour is stops, play and record buttons are enabled,
> stop button is disabled, value of progress bar is set to 0.
> Move record button to the right of the stop button and tweak it's behavion.
> If playlist doesn't contains "FlyTo", "Wait", "TourControl" play\record buttons are disabled.
> Fix behavion of up/down buttons.
> Disable editing duration of first element of mainTrack if it's FlyTo and use 0 as it's duration.
> Use QPersistentModelIndex where it's necessary.
>
>
> Diffs
> -----
>
> src/lib/marble/FlyToEditWidget.h 9aa8e2c
> src/lib/marble/FlyToEditWidget.cpp 775a9e2
> src/lib/marble/PlaybackFlyToItem.h 0b5c330
> src/lib/marble/PlaybackFlyToItem.cpp 77af4f3
> src/lib/marble/SerialTrack.cpp 24557a1
> src/lib/marble/SoundCueEditWidget.h 3cb9751
> src/lib/marble/TourControlEditWidget.h c706349
> src/lib/marble/TourItemDelegate.h 703a1d3
> src/lib/marble/TourItemDelegate.cpp 2699354
> src/lib/marble/TourPlayback.h f936b86
> src/lib/marble/TourPlayback.cpp 1f8220a
> src/lib/marble/TourWidget.h 801083b
> src/lib/marble/TourWidget.cpp d4c7252
> src/lib/marble/TourWidget.ui 57c8799
> src/lib/marble/WaitEditWidget.h f7c4285
>
> Diff: https://git.reviewboard.kde.org/r/121751/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/30/0d760c97-73cd-46a2-8ad4-8e96f5d507b9__Change_toolbuttons_for_tour_ui.png
>
>
> Thanks,
>
> Mihail Ivchenko
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141230/505ad618/attachment.html>
More information about the Marble-devel
mailing list