[Marble-devel] Review Request 121713: [GCI] Fix the crash on saving the Tour

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121713/#review72598
-----------------------------------------------------------



src/lib/marble/GeoDataTreeModel.h
<https://git.reviewboard.kde.org/r/121713/#comment50595>

    Hm, so this set of methods is supposed to be an addition similar to addFeature/removeFeature and addDocument/removeDocument?
    Shouldn't it also be available as a slot?
    Shouldn't it have a similar order of parameters (currently you have the rows at the beginning while in the other case they appear at the end).
    
    Shouldn't the return value be the same? If the row allows for a default parameter we should maybe also call this addTourPrimitive() so that it's consistent with addFeature()



src/lib/marble/GeoDataTreeModel.h
<https://git.reviewboard.kde.org/r/121713/#comment50596>

    Typo Alarm: Ptimitives


- Torsten Rahn


On Dez. 28, 2014, 2:29 nachm., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121713/
> -----------------------------------------------------------
> 
> (Updated Dez. 28, 2014, 2:29 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> GCI task: http://www.google-melange.com/gci/task/view/google/gci2014/5837060422238208
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/GeoDataTreeModel.h 8fcdde8 
>   src/lib/marble/GeoDataTreeModel.cpp 0e7e037 
>   src/lib/marble/TourWidget.cpp 11a00e2 
>   src/lib/marble/layers/GeometryLayer.cpp 6b2bb60 
> 
> Diff: https://git.reviewboard.kde.org/r/121713/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141228/e4663655/attachment.html>