[Marble-devel] Review Request 121682: [GCI] Fix FlyTo functionality.

Torsten Rahn tackat at kde.org
Fri Dec 26 18:40:19 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121682/#review72531
-----------------------------------------------------------

Ship it!


Ship It!

- Torsten Rahn


On Dez. 26, 2014, 4:57 nachm., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121682/
> -----------------------------------------------------------
> 
> (Updated Dez. 26, 2014, 4:57 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> GCI task: https://www.google-melange.com/gci/task/view/google/gci2014/5885868430589952
> 
> GeoDataLookAt had 0 altitude, so in TourPlayback::centerOn GeoDataLookAt::setRange is called with range = 0. Then, in MarbleAbstractPresenter::flyTo it doesn't pass the check for zoom range.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/FlyToEditWidget.cpp 18c4701 
>   src/lib/marble/TourWidget.cpp f8bca19 
>   src/lib/marble/WaitEditWidget.cpp 5914b6a 
> 
> Diff: https://git.reviewboard.kde.org/r/121682/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141226/b148c624/attachment-0001.html>


More information about the Marble-devel mailing list