[Marble-devel] Review Request 121675: Refactoring measure config dialog

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Thu Dec 25 23:07:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121675/
-----------------------------------------------------------

(Updated Dec. 26, 2014, 1:07 a.m.)


Review request for Marble and Torsten Rahn.


Changes
-------

Copyright headers added


Repository: marble


Description
-------

This patch does:

- integrate http://devel-home.kde.org/~tackat/MeasureConfigWidget.ui file
- add all required UI functionality for config dialog

Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5810142251581440


Diffs (updated)
-----

  src/plugins/render/measure/MeasureToolPlugin.h cdcb459 
  src/plugins/render/measure/MeasureToolPlugin.cpp e9487ae 
  src/plugins/render/measure/MeasureConfigDialog.cpp PRE-CREATION 
  src/plugins/render/measure/MeasureConfigDialog.ui PRE-CREATION 
  src/plugins/render/measure/MeasureConfigWidget.ui 2b38faf 
  src/plugins/render/measure/CMakeLists.txt 96c83d1 
  src/plugins/render/measure/MeasureConfigDialog.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121675/diff/


Testing
-------

Complete proper UX testing.


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141225/920a8703/attachment-0001.html>


More information about the Marble-devel mailing list