[Marble-devel] Review Request 121662: Adding circular measure tool

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Thu Dec 25 12:47:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121662/
-----------------------------------------------------------

(Updated Dec. 25, 2014, 2:47 p.m.)


Review request for Marble, Bernhard Beschow, Dennis Nienhüser, and Torsten Rahn.


Repository: marble


Description
-------

This patch adds a circular mode to Measure Plugin, which basically changes behaviour of Measure Plugin:

- You can use up to 2 points only
- A semi-transparent circle with center in 1st point and radius in 2nd is drawn

Related GCI task: https://www.google-melange.com/gci/task/view/google/gci2014/5900609429438464 


Diffs
-----

  src/plugins/render/measure/MeasureConfigWidget.ui 7b7b834 
  src/plugins/render/measure/MeasureToolPlugin.h 87fe3d7 
  src/plugins/render/measure/MeasureToolPlugin.cpp 5c5f699 

Diff: https://git.reviewboard.kde.org/r/121662/diff/


Testing
-------

Visual testing


File Attachments (updated)
----------------

Dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/24/e3b41801-bc7f-41df-8d64-ee16d78be754__Screen_Shot_2014-12-24_at_3.01.14_PM.png
Measure
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/25/f93920b6-323c-4c6b-985f-8ac84cbadaf0__Screen_Shot_2014-12-25_at_2.46.29_PM.png


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141225/5bd5a972/attachment.html>


More information about the Marble-devel mailing list