[Marble-devel] Review Request 121662: Adding circular measure tool

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Wed Dec 24 14:55:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121662/
-----------------------------------------------------------

(Updated Dec. 24, 2014, 4:55 p.m.)


Review request for Marble, Bernhard Beschow, Dennis Nienhüser, and Torsten Rahn.


Repository: marble


Description
-------

This patch adds a circular mode to Measure Plugin, which basically changes behaviour of Measure Plugin:

- You can use up to 2 points only
- A semi-transparent circle with center in 1st point and radius in 2nd is drawn

Related GCI task: https://www.google-melange.com/gci/task/view/google/gci2014/5900609429438464 


Diffs (updated)
-----

  src/plugins/render/measure/MeasureConfigWidget.ui 7b7b834 
  src/plugins/render/measure/MeasureToolPlugin.h 87fe3d7 
  src/plugins/render/measure/MeasureToolPlugin.cpp 5c5f699 

Diff: https://git.reviewboard.kde.org/r/121662/diff/


Testing
-------

Visual testing


File Attachments
----------------

Circular measure
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/24/dc67b117-b25e-41ab-a3fb-7a3ba09c78a6__Screen_Shot_2014-12-24_at_2.58.37_PM.png
Dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/24/e3b41801-bc7f-41df-8d64-ee16d78be754__Screen_Shot_2014-12-24_at_3.01.14_PM.png


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141224/f7ad32a9/attachment.html>


More information about the Marble-devel mailing list