[Marble-devel] Review Request 121518: [GCI] Refactored header of the addplacemark\bookmark\addgroundoverlay dialogs

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121518/#review72000
-----------------------------------------------------------



src/lib/marble/PlacemarkEditHeader.h
<https://git.reviewboard.kde.org/r/121518/#comment50201>

    const & for QString please



src/lib/marble/PlacemarkEditHeader.h
<https://git.reviewboard.kde.org/r/121518/#comment50202>

    See above.



src/lib/marble/PlacemarkEditHeader.cpp
<https://git.reviewboard.kde.org/r/121518/#comment50205>

    Hm, booleans as parameters don't work well since the meaning of them is not inituitively clear.
    What about having a "selectAll()" method like for QLineEdit::selectAll() ?


- Torsten Rahn


On Dez. 14, 2014, 6:31 nachm., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121518/
> -----------------------------------------------------------
> 
> (Updated Dez. 14, 2014, 6:31 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> GCI task: http://www.google-melange.com/gci/task/view/google/gci2014/5790139062157312
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/EditTextAnnotationDialog.cpp 2716195 
>   src/plugins/render/annotate/EditTextAnnotationDialog.ui 17b4c0d 
>   src/lib/marble/PlacemarkEditHeader.cpp PRE-CREATION 
>   src/lib/marble/PlacemarkEditHeader.ui PRE-CREATION 
>   src/plugins/render/annotate/EditGroundOverlayDialog.h baac152 
>   src/plugins/render/annotate/EditGroundOverlayDialog.cpp eadf7ee 
>   src/plugins/render/annotate/EditGroundOverlayDialog.ui 88c2cbe 
>   src/lib/marble/CMakeLists.txt b6c0226 
>   src/lib/marble/EditBookmarkDialog.h 351353f 
>   src/lib/marble/EditBookmarkDialog.cpp 62d2e5a 
>   src/lib/marble/EditBookmarkDialog.ui e93bacb 
>   src/lib/marble/PlacemarkEditHeader.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121518/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141214/4daa5e3b/attachment.html>