[Marble-devel] Review Request 121488: Warning in case of no movie capture tools

Torsten Rahn tackat at kde.org
Sun Dec 14 12:24:47 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121488/#review71971
-----------------------------------------------------------

Ship it!


Ship It!

- Torsten Rahn


On Dez. 14, 2014, 12:21 nachm., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121488/
> -----------------------------------------------------------
> 
> (Updated Dez. 14, 2014, 12:21 nachm.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Bugs: 340467
>     http://bugs.kde.org/show_bug.cgi?id=340467
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Currently, if you don't have avconv/ffmpeg installed on your machine, you can't capture video from MarbleWidget. There is still an unexpected behaviour. Even if you don't have corresponding tools installed, Marble still will behave like it's recording, but in fact, it won't. This patch fixes the whole thing.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MovieCapture.h 1e37f5b 
>   src/lib/marble/MovieCapture.cpp 1b79ecd 
>   src/lib/marble/MovieCaptureDialog.cpp 2d6d041 
> 
> Diff: https://git.reviewboard.kde.org/r/121488/diff/
> 
> 
> Testing
> -------
> 
> Built & run, visual testing
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141214/145cc073/attachment.html>


More information about the Marble-devel mailing list