[Marble-devel] Review Request 121395: Adding AbstractProjection::boundingLinearRing()

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121395/#review71697
-----------------------------------------------------------



src/plugins/render/overviewmap/OverviewMap.cpp
<https://git.reviewboard.kde.org/r/121395/#comment49990>

    gpainter => geopainter (no abbreviations)



src/plugins/render/overviewmap/OverviewMap.cpp
<https://git.reviewboard.kde.org/r/121395/#comment49991>

    why disable antialiasing here?



src/plugins/render/overviewmap/OverviewMap.cpp
<https://git.reviewboard.kde.org/r/121395/#comment49992>

    why grayish and not plain white (255)?


- Dennis Nienhüser


On Dec. 10, 2014, 10:32 a.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121395/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 10:32 a.m.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> GCI-2014 related task: https://www.google-melange.com/gci/task/view/google/gci2014/6356744502509568
> 
> Newly added method allows to avoid zig-zag lines appearing while sampling GeoDataLatLonAltBox. Moving forward to sample a good n-side polygon.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/overviewmap/OverviewMap.cpp 1408261 
>   src/plugins/render/overviewmap/OverviewMap.h 4c9ada8 
>   src/lib/marble/projections/AbstractProjection.h 719e9f8 
>   src/lib/marble/projections/AbstractProjection.cpp 591adc0 
> 
> Diff: https://git.reviewboard.kde.org/r/121395/diff/
> 
> 
> Testing
> -------
> 
> Visual testing, works as expected.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2014-12-09 at 3.42.41 PM.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/6924aa58-3b28-4bab-9d3b-8adaf759afd1__Screen_Shot_2014-12-09_at_3.42.41_PM.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141210/74ce0393/attachment.html>