[Marble-devel] Review Request 121362: Fixing a memory leak from GeometryLayerPrivate + some various fixes
Illya Kovalevskyy
illya.kovalevskyy at gmail.com
Sun Dec 7 13:57:05 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121362/
-----------------------------------------------------------
(Updated Dec. 7, 2014, 1:57 p.m.)
Status
------
This change has been marked as submitted.
Review request for Marble, Dennis Nienhüser and Torsten Rahn.
Repository: marble
Description
-------
Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5790648552652800
+ 200k leak from GeometryLayerPrivate::createGraphicsItemFromGeometry() neutralized
+ MarbleLegendBrowser reworked
Diffs
-----
src/lib/marble/GeoGraphicsScene.h 6073751
src/lib/marble/GeoGraphicsScene.cpp 390d868
src/lib/marble/MarbleLegendBrowser.cpp 766e813
src/lib/marble/MarbleModel.h 4636b6f
src/lib/marble/MarbleModel.cpp c71c9cc
src/lib/marble/layers/GeometryLayer.cpp 4b488e0
Diff: https://git.reviewboard.kde.org/r/121362/diff/
Testing
-------
Double valgrind-check (inb4 the fix and after)
Thanks,
Illya Kovalevskyy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141207/83e9c934/attachment.html>
More information about the Marble-devel
mailing list