[Marble-devel] Review Request 121362: Fixing a memory leak from GeometryLayerPrivate + some various fixes

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121362/#review71507
-----------------------------------------------------------



src/lib/marble/GeoGraphicsScene.cpp
<https://git.reviewboard.kde.org/r/121362/#comment49879>

    i don't think we need this



src/lib/marble/MarbleModel.h
<https://git.reviewboard.kde.org/r/121362/#comment49877>

    Don't forget the description of what the method actually does. E.g
    
    "Uses the given text document as the new content of the legend. Any previous legend content is overwritten. MarbleModel takes ownership of the passed document."



src/lib/marble/layers/GeometryLayer.cpp
<https://git.reviewboard.kde.org/r/121362/#comment49878>

    i think these two lines need to remain here. The items in d->m_items are screen overlay instances that are handled by the geometry layer itself and not known to the graphics scene.


- Dennis Nienhüser


On Dec. 7, 2014, 12:40 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121362/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2014, 12:40 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5790648552652800
> 
> + 200k leak from GeometryLayerPrivate::createGraphicsItemFromGeometry() neutralized
> + MarbleLegendBrowser reworked
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/GeoGraphicsScene.h 6073751 
>   src/lib/marble/GeoGraphicsScene.cpp 390d868 
>   src/lib/marble/MarbleLegendBrowser.cpp 766e813 
>   src/lib/marble/MarbleModel.h 4636b6f 
>   src/lib/marble/MarbleModel.cpp c71c9cc 
>   src/lib/marble/layers/GeometryLayer.cpp 4b488e0 
> 
> Diff: https://git.reviewboard.kde.org/r/121362/diff/
> 
> 
> Testing
> -------
> 
> Double valgrind-check (inb4 the fix and after)
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141207/bf867f88/attachment.html>