[Marble-devel] Review Request 120030: Multiple sessions

Gábor Péterffy peterffy95 at gmail.com
Sun Dec 7 09:49:49 UTC 2014



> On dec. 3, 2014, 10:09 du, Bernhard Beschow wrote:
> > src/lib/marble/MarbleAbstractPresenter.cpp, line 616
> > <https://git.reviewboard.kde.org/r/120030/diff/4/?file=309706#file309706line616>
> >
> >     What happens if model != m_map->model()?

Can you explain in which situations can this happen?


> On dec. 3, 2014, 10:09 du, Bernhard Beschow wrote:
> > src/lib/marble/SessionManager.cpp, line 179
> > <https://git.reviewboard.kde.org/r/120030/diff/4/?file=309709#file309709line179>
> >
> >     Why not simply use a stack (or two, for going forward in history) here?

Because, this feature can be used in multiple ways. You can use it as history, but you can also improve it to do other things too like support high resolution printing with creating a session in the background or change between sessions without closing any.


> On dec. 3, 2014, 10:09 du, Bernhard Beschow wrote:
> > src/lib/marble/SessionManager.cpp, line 71
> > <https://git.reviewboard.kde.org/r/120030/diff/4/?file=309709#file309709line71>
> >
> >     The routing layer is a value member (i.e. not a pointer) in MarbleWidget. So what's this attribute here supposed to do?

Hm, I checked the source code and it is definitly a pointer not a value member in my revision.


- Gábor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120030/#review71306
-----------------------------------------------------------


On szept. 4, 2014, 5 du, Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120030/
> -----------------------------------------------------------
> 
> (Updated szept. 4, 2014, 5 du)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Adds the ability to save sessions at runtime and start a new one and later return to the previous one.
> 
> -This could be improved with adding the ability to change between sessions without closing any.
> -Also it could be improved/used up to create an undo ability (Maybe with QUndo?)
> -It could be used up to support high resolution printing with creating a session in the background
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/SessionManager.h PRE-CREATION 
>   src/lib/marble/SessionManager.cpp PRE-CREATION 
>   src/lib/marble/CMakeLists.txt 482a241a4e61fc26cede3b9140cbd320016d0ac2 
>   src/lib/marble/MarbleAbstractPresenter.h 9518e7e77797d026d78d4740a8c813c943868883 
>   src/lib/marble/MarbleAbstractPresenter.cpp ecb29cb90826c421ef90f423466f344bdbb498ac 
>   src/lib/marble/MarbleWidget.cpp 75d2d8f63021e5c278f5e57e30f03f093b068943 
> 
> Diff: https://git.reviewboard.kde.org/r/120030/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141207/b74b145d/attachment-0001.html>


More information about the Marble-devel mailing list