[Marble-devel] Review Request 121362: Fixing a memory leak coming from GeometryLayerPrivate::createGraphicsItemFromGeometry()

[Illya Kovalevskyy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121362/
-----------------------------------------------------------

(Updated Dec. 6, 2014, 11:04 p.m.)


Review request for Marble, Dennis Nienhüser and Torsten Rahn.


Repository: marble


Description
-------

Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5790648552652800

Valgrind detected a memory leak for approx 2k bytes in GeometryLayerPrivate::createGraphicsItemFromGeometry() function. That method adds newly created GeoGraphicsItem to the GeoGraphicsScene instance, which doesn't take care of newly created object. I tweaked code a bit so it cleans all items added.

Leak has been neutralized.


Diffs (updated)
-----

  src/lib/marble/GeoGraphicsScene.cpp 390d868 
  src/lib/marble/MarbleModel.cpp c71c9cc 

Diff: https://git.reviewboard.kde.org/r/121362/diff/


Testing
-------

Double valgrind-check (inb4 the fix and after)


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141206/39c81b16/attachment-0001.html>