[Marble-devel] Review Request 121370: Fixing critical memory leaks in Pn2Runner

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121370/#review71486
-----------------------------------------------------------



src/plugins/runner/pn2/Pn2Runner.cpp
<https://git.reviewboard.kde.org/r/121370/#comment49867>

    This is not correct for the linearring case.



src/plugins/runner/pn2/Pn2Runner.cpp
<https://git.reviewboard.kde.org/r/121370/#comment49868>

    See above


- Dennis Nienhüser


On Dez. 6, 2014, 6:21 nachm., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121370/
> -----------------------------------------------------------
> 
> (Updated Dez. 6, 2014, 6:21 nachm.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Valgrind detected massive memory leak (on my machine it was up to 15 MB on application launch). It was all about passing newly created object and not deleting it later. Patch closes all memory leaks from Pn2Runner.
> 
> GCI-2014 related task: http://www.google-melange.com/gci/task/view/google/gci2014/6687014871105536
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/pn2/Pn2Runner.cpp ce5dca2 
> 
> Diff: https://git.reviewboard.kde.org/r/121370/diff/
> 
> 
> Testing
> -------
> 
> Double valgrind run (w/o and with fixes).
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141206/d40e4a9d/attachment.html>