[Marble-devel] Review Request 121362: Fixing a memory leak coming from GeometryLayerPrivate::createGraphicsItemFromGeometry()
Illya Kovalevskyy
illya.kovalevskyy at gmail.com
Fri Dec 5 21:27:06 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121362/
-----------------------------------------------------------
Review request for Marble, Dennis Nienhüser and Torsten Rahn.
Repository: marble
Description
-------
Valgrind detected a memory leak for approx 2k bytes in GeometryLayerPrivate::createGraphicsItemFromGeometry() function. That method adds newly created GeoGraphicsItem to the GeoGraphicsScene instance, which doesn't take care of newly created object. I tweaked code a bit so it cleans all items added.
Leak has been neutralized.
Diffs
-----
src/lib/marble/GeoGraphicsScene.cpp 390d868
Diff: https://git.reviewboard.kde.org/r/121362/diff/
Testing
-------
Double valgrind-check (inb4 the fix and after)
Thanks,
Illya Kovalevskyy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141205/f13aad6e/attachment.html>
More information about the Marble-devel
mailing list