[Marble-devel] Review Request 121319: TourWidget user interface tweaks for FlyTo items

[Sanjiban Bairagya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121319/#review71220
-----------------------------------------------------------


The user interface change looks pretty accurate to me.

- Sanjiban Bairagya


On Dec. 2, 2014, 3:44 a.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121319/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 3:44 a.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Sanjiban Bairagya.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch basically tweaks edit mode of FlyTo items in TourWidget:
> 
> + Useless label changed to functional "center"-button
> + Added 'duration' spin box
> + UX changed a bit, now it makes more sense
> 
> There is still a bug, after duration change, duration of the FlyTo item doesn't really change at all, but the property itself is changed.
> 
> Related GCI-2014 task: https://www.google-melange.com/gci/task/view/google/gci2014/5278546247286784
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/TourWidget.h 2f42804 
>   src/lib/marble/TourWidget.cpp 2774f14 
>   src/lib/marble/libmarble.qrc 921d11f 
> 
> Diff: https://git.reviewboard.kde.org/r/121319/diff/
> 
> 
> Testing
> -------
> 
> UI/UX testing
> 
> 
> File Attachments
> ----------------
> 
> Updated UI
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/12/01/def5367a-a16b-4cee-85d1-344925c642f0__Screen_Shot_2014-12-02_at_12.01.35_AM.png
> Old UI
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/12/01/c9c383e5-04fe-40d9-859b-dd8826e1b888__Screen_Shot_2014-12-02_at_12.11.53_AM.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141201/3168d76f/attachment-0001.html>