[Marble-devel] Review Request 120013: Creating GeoSceneDocument from GeoDataPhotoOverlay

[Torsten Rahn]

> On Aug. 31, 2014, 10:26 vorm., Gábor Péterffy wrote:
> > src/lib/marble/MapThemeManager.cpp, line 552
> > <https://git.reviewboard.kde.org/r/120013/diff/1/?file=308823#file308823line552>
> >
> >     <limits> used here
> 
> Torsten Rahn wrote:
>     What about using qMax there instead?

Ah sorry, qMax isn't the same.


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120013/#review65572
-----------------------------------------------------------


On Aug. 31, 2014, 10:04 vorm., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120013/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2014, 10:04 vorm.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch contains the code to create GeoSceneDocument from a GeoDataPhotoOverlay, and a modification which enables to MarbleModel to use a preset GeoSceneDocument.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MapThemeManager.h d18c8de6ec29153e00d079a4b30579ca1d9be14d 
>   src/lib/marble/MapThemeManager.cpp 725cc44614073b2ee114a448ce08254ceffa4f5d 
>   src/lib/marble/MarbleModel.h 9643186b62429a4e04f421030d64b8ab86cd7f7c 
>   src/lib/marble/MarbleModel.cpp 5f1b88ae1ed4d19562ff8f7b3f0783a98f691685 
> 
> Diff: https://git.reviewboard.kde.org/r/120013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140831/3432399c/attachment.html>