[Marble-devel] Review Request 119922: Lazily initialize static RemoteIconLoader in GeoDataIconStylePrivate to avoid application hang when loading marble library

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119922/#review65147
-----------------------------------------------------------

Ship it!


Looks good.

- Dennis Nienhüser


On Aug. 24, 2014, 5:55 nachm., Philippe Renon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119922/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2014, 5:55 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Fixes application hang when loading marble library
> See https://forum.kde.org/viewtopic.php?f=217&t=122566 for details.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataIconStyle.cpp a1c8dc0 
> 
> Diff: https://git.reviewboard.kde.org/r/119922/diff/
> 
> 
> Testing
> -------
> 
> Tested under ubuntu 14.04 both with Qt 5.2.1 and 5.3.1.
> 
> Please note that the RemoreIconLoader feature itself has not been tested as I don't know how to trigger its use.
> 
> 
> Thanks,
> 
> Philippe Renon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140824/253a441c/attachment.html>