[Marble-devel] Review Request 119649: Gnomonic projection, created by Bernhard Beschow

[Torsten Rahn]

> On Aug. 20, 2014, 10:02 vorm., Gábor Péterffy wrote:
> > Something is wrong at the creation of the coastline, but it is very strange because every other thing is drawn correctly.
> > Image: http://ibin.co/1XStBMkdRFzv
> 
> Gábor Péterffy wrote:
>     This image is the created m_coastline ^

There are a few possible "usual suspects" for this kind of drawing bug.  
1. Most likely: a tesselation issue. If you force to turn off tesselation for all LinearRings/Polygons, does this resolve the issue?
2. Very likely cause: The code which determines based on horizon crossing how the polygon should be filled. Bug based on this should only occur at a certain point of rotating the globe at a low zoom level where you almost see the whole earth. 
3. Another possible cause: nodes get filtered away during runtime - based on whether their distance to the next node for the current zoom can still be resolved. Bugs based on this code should only happen for a certain zoomlevel ...  
4. Least likely: ClipPainter (does turning off clipping resolve it?)


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119649/#review64897
-----------------------------------------------------------


On Aug. 20, 2014, 9:55 vorm., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119649/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 9:55 vorm.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch contains the the support for gnomonic projection.
> 
> Created by Bernhard Beschow.
> 
> Origin: https://github.com/shentok/marble/tree/streetview
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CMakeLists.txt 532ec3d3e63bd78e06600f0c11a2ee653f56a721 
>   src/lib/marble/MapViewWidget.h 9a86c1e5d06df2a1ed44eab8f10544cf3b8acc7e 
>   src/plugins/declarative/MarbleDeclarativeWidget.cpp 0cb6c94d584f385317caa8e88f19fbfec57a5a95 
>   src/lib/marble/MapViewWidget.cpp b55dc1cfbf5caa7d44846bedaf048648009a6076 
>   src/lib/marble/MarbleGlobal.h 69a96f3badc69edc36a0163a173f7214fe71aeb5 
>   src/lib/marble/ViewportParams.cpp d6cf03603b353671f52440adcea15ddecf188b94 
>   src/lib/marble/layers/TextureLayer.cpp 845b032c7b7603af5af0bdb9064b01e0a0817af3 
>   src/lib/marble/projections/AzimuthalProjection.h PRE-CREATION 
>   src/lib/marble/projections/AzimuthalProjection.cpp PRE-CREATION 
>   src/lib/marble/projections/AzimuthalProjection_p.h PRE-CREATION 
>   src/lib/marble/projections/GnomonicProjection.h PRE-CREATION 
>   src/lib/marble/projections/GnomonicProjection.cpp PRE-CREATION 
>   src/lib/marble/projections/SphericalProjection.h 865407da4e67a6bcdc07fb7bb83ab5f4e7ab7a20 
>   src/lib/marble/projections/SphericalProjection.cpp 669851ee72d89a128814de8e7575d6db4ce5db15 
> 
> Diff: https://git.reviewboard.kde.org/r/119649/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140820/cb29d963/attachment.html>