[Marble-devel] Review Request 119264: Added " identify the country shape" game.

[Abhinav Gangwar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119264/
-----------------------------------------------------------

(Updated Aug. 15, 2014, 12:41 a.m.)


Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.


Changes
-------

Modifications to previous patch :
1. In game classes ( CountryByShape.cpp, CountryByFlag.cpp and ClickOnThat.cpp ), don't use FileManager::at(..) to fetch GeoDataDcument for a data file as FileManager isn't supposed to visible outside marble lib. Instead use tree model to fetch required GeoDataDocument.
2. Put all qml files in a qrc file ( marbleGame.qrc ).
3. Have some GeoDataDocument objects as data members for game classes ( CountryByShape, CountryByFlag etc. ), which are required to be queried to create questions, instead of fetching them from GeoDataTreeModel/FileManager everytime posting a question. Initialize these GeoDataDocuments in $GameClass::initiateGame() by fetching them from tree model. Enhances performance.


Repository: marble


Description
-------

Added "identify the country shape" game.
1. Game randomly highlights a country on political map.
2. It displays random answer options out of which only one is correct. The user needs to check the button 
   displaying correct option.

Here is a video showing the game http://youtu.be/kr0HsxLWXPs .

Here is a new video showing the new UI ( with qtquick 2.0 ) in left dock widget panel which now shows a QQuickView window. http://youtu.be/o-6ZTkqWxrw

The game needs the patch https://git.reviewboard.kde.org/r/118717/ to work.


Diffs (updated)
-----

  src/apps/CMakeLists.txt 022cd02 
  src/apps/marble-game/CMakeLists.txt PRE-CREATION 
  src/apps/marble-game/ClickOnThat.h PRE-CREATION 
  src/apps/marble-game/ClickOnThat.cpp PRE-CREATION 
  src/apps/marble-game/ClickOnThat.qml PRE-CREATION 
  src/apps/marble-game/CountryByFlag.h PRE-CREATION 
  src/apps/marble-game/CountryByFlag.cpp PRE-CREATION 
  src/apps/marble-game/CountryByFlag.qml PRE-CREATION 
  src/apps/marble-game/CountryByShape.h PRE-CREATION 
  src/apps/marble-game/CountryByShape.cpp PRE-CREATION 
  src/apps/marble-game/CountryByShape.qml PRE-CREATION 
  src/apps/marble-game/CustomButton.qml PRE-CREATION 
  src/apps/marble-game/CustomRadioButton.qml PRE-CREATION 
  src/apps/marble-game/GameMainWindow.h PRE-CREATION 
  src/apps/marble-game/GameMainWindow.cpp PRE-CREATION 
  src/apps/marble-game/GameOptions.qml PRE-CREATION 
  src/apps/marble-game/GamesView.qml PRE-CREATION 
  src/apps/marble-game/Window.qml PRE-CREATION 
  src/apps/marble-game/game.ui PRE-CREATION 
  src/apps/marble-game/gamemain.cpp PRE-CREATION 
  src/apps/marble-game/marbleGame.qrc PRE-CREATION 
  data/bitmaps/fixing-pin.png PRE-CREATION 
  data/bitmaps/target.png PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119264/diff/


Testing
-------

Works fine here :) .


File Attachments
----------------

game.diff
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/14/d66172dc-0395-45a1-90de-403b411d1a5f__game.diff


Thanks,

Abhinav Gangwar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140814/603ac474/attachment.html>