[Marble-devel] Review Request 119782: Polishes video-writing from tours

Dennis Nienhüser earthwings at gentoo.org
Thu Aug 14 16:14:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119782/#review64534
-----------------------------------------------------------

Ship it!


Looks good.

- Dennis Nienhüser


On Aug. 14, 2014, 3:56 p.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119782/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 3:56 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> videos are getting written clearly from tours now, for every type of tour possible.
> .avi, .mkv files can be written from tours now.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MovieCapture.cpp c4322cb 
>   src/lib/marble/TourCaptureDialog.h e3344ed 
>   src/lib/marble/TourCaptureDialog.cpp f5b4416 
> 
> Diff: https://git.reviewboard.kde.org/r/119782/diff/
> 
> 
> Testing
> -------
> 
> Tested with custom .kml tour files. Works for both Earth and Moon, and its different map types. I have tested creating the video of the tour in both mkv and avi formats and it has written fine for both.
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140814/88e5af7e/attachment.html>


More information about the Marble-devel mailing list