[Marble-devel] Review Request 119649: Gnomonic projection, created by Bernhard Beschow

Torsten Rahn tackat at kde.org
Thu Aug 7 15:32:27 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119649/#review63992
-----------------------------------------------------------


Curious question: since SphericalProjection and GnomonicProjection share some similarities, would it be possible/make sense to have them both inherited from a common class? This would be similar to FlatProjection and MercatorProjection inheriting from CylindricalProjection ...

- Torsten Rahn


On Aug. 7, 2014, 3:10 nachm., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119649/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 3:10 nachm.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch contains the the support for gnomonic projection.
> 
> Created by Bernhard Beschow.
> 
> Origin: https://github.com/shentok/marble/tree/streetview
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CMakeLists.txt e809639ed1436b2775893c63de320d81b0ea6135 
>   src/lib/marble/GnomonicScanlineTextureMapper.h PRE-CREATION 
>   src/lib/marble/GnomonicScanlineTextureMapper.cpp PRE-CREATION 
>   src/lib/marble/MarbleGlobal.h 69a96f3badc69edc36a0163a173f7214fe71aeb5 
>   src/lib/marble/ViewportParams.cpp d6cf03603b353671f52440adcea15ddecf188b94 
>   src/lib/marble/layers/TextureLayer.cpp 845b032c7b7603af5af0bdb9064b01e0a0817af3 
>   src/lib/marble/projections/GnomonicProjection.h PRE-CREATION 
>   src/lib/marble/projections/GnomonicProjection.cpp PRE-CREATION 
>   src/plugins/declarative/MarbleDeclarativeWidget.cpp 0cb6c94d584f385317caa8e88f19fbfec57a5a95 
> 
> Diff: https://git.reviewboard.kde.org/r/119649/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140807/2a412230/attachment.html>


More information about the Marble-devel mailing list