[Marble-devel] Review Request 117188: Added support for kml tag SchemaData and SimpleData

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117188/#review63702
-----------------------------------------------------------

Ship it!



src/lib/marble/geodata/data/GeoDataSchemaData.h
<https://git.reviewboard.kde.org/r/117188/#comment44371>

    const GeoNode *parent() const;
    or
    GeoNode *parent();
    or both of them



src/lib/marble/geodata/handlers/kml/KmlSimpleArrayDataTagHandler.cpp
<https://git.reviewboard.kde.org/r/117188/#comment44370>

    please remove the qdebug


- Dennis Nienhüser


On Aug. 2, 2014, 6:25 p.m., Abhinav Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117188/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2014, 6:25 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added support for kml tag SchemaData and its child element SimpleData.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/writers/kml/KmlExtendedDataTagWriter.cpp fed66a1 
>   src/lib/marble/geodata/writers/kml/KmlSchemaDataTagWriter.h PRE-CREATION 
>   src/lib/marble/geodata/writers/kml/KmlSchemaDataTagWriter.cpp PRE-CREATION 
>   src/lib/marble/geodata/writers/kml/KmlSchemaTagWriter.h 89532b5 
>   src/lib/marble/geodata/writers/kml/KmlSimpleDataTagWriter.h PRE-CREATION 
>   src/lib/marble/geodata/writers/kml/KmlSimpleDataTagWriter.cpp PRE-CREATION 
>   src/lib/marble/geodata/writers/kml/KmlSimpleFieldTagWriter.h d830050 
>   tests/TestEquality.cpp d1e34a5 
>   tests/data/schemaData.kml PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp 2870dd1 
>   src/lib/marble/geodata/handlers/kml/KmlSchemaDataTagHandler.cpp a81c49f 
>   src/lib/marble/geodata/handlers/kml/KmlSimpleArrayDataTagHandler.cpp 616e6b9 
>   src/lib/marble/geodata/handlers/kml/KmlSimpleDataTagHandler.h PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlSimpleDataTagHandler.cpp PRE-CREATION 
>   src/lib/marble/geodata/parser/GeoDataTypes.h b048331 
>   src/lib/marble/geodata/parser/GeoDataTypes.cpp 413eef2 
>   src/lib/marble/geodata/data/GeoDataSimpleData.h PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataSimpleData.cpp PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h cf616e1 
>   src/lib/marble/geodata/CMakeLists.txt faffc39 
>   src/lib/marble/geodata/data/GeoDataExtendedData.h 37f76fb 
>   src/lib/marble/geodata/data/GeoDataExtendedData.cpp 219aab4 
>   src/lib/marble/geodata/data/GeoDataExtendedData_p.h 99cfc0d 
>   src/lib/marble/geodata/data/GeoDataSchemaData.h PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataSchemaData.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117188/diff/
> 
> 
> Testing
> -------
> 
> Works fine on my system
> 
> 
> Thanks,
> 
> Abhinav Gangwar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140803/d5322b9a/attachment.html>