[Marble-devel] Review Request 117572: Marble headers are not installed when platform is APPLE and QTONLY is set

Philippe Renon philippe_renon at yahoo.fr
Wed Apr 30 22:43:42 UTC 2014



> On April 14, 2014, 11:21 p.m., Dennis Nienhüser wrote:
> >
> 
> Philippe Renon wrote:
>     I don't have commit rights so can't ship it :(
> 
> Dennis Nienhüser wrote:
>     I'm just with a smartphone for the next weeks. Can someone push on Philippe's behalf, please?

Hi Dennis,

Hope you had a nice vacation or trip or whatever kept you afk :)

Could you push this patch on my behalf ?

Regards,
Philippe.


- Philippe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117572/#review55782
-----------------------------------------------------------


On April 14, 2014, 9:52 p.m., Philippe Renon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117572/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 9:52 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Marble headers are not installed when platform is APPLE and QTONLY is set.
> 
> The reason for that is unknown and prevents doing external Qt builds on Mac.
> 
> This patch removes this limitation.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CMakeLists.txt 471cecf 
> 
> Diff: https://git.reviewboard.kde.org/r/117572/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Philippe Renon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140430/a7586531/attachment.html>


More information about the Marble-devel mailing list