[Marble-devel] Review Request 117416: Bug 333119 - Equality operators for track related classes

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117416/#review56559
-----------------------------------------------------------



src/lib/marble/geodata/data/GeoDataMultiTrack.cpp
<https://git.reviewboard.kde.org/r/117416/#comment39464>

    Wouldn't this one trigger if the sizes differ?



src/lib/marble/geodata/data/GeoDataTrack.cpp
<https://git.reviewboard.kde.org/r/117416/#comment39465>

    You cannot work on m_line string* here because of the lazy update logic. Instead compare lineString() to other.lineString() and ideally also Q_ASSERT on the needsUpdate variables being false both after calling lineString(). Alternatively ignore both variables in the equality check since they provide redundant data.


- Dennis Nienhüser


On April 7, 2014, 8:45 a.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117416/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 8:45 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 333119
>     http://bugs.kde.org/show_bug.cgi?id=333119
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added operator== and operator!= to the classes GeoDataTrack and GeoDataMultiTrack. 
> Extended TestEquality by a new unit test method for each class which verifies the implementation for several instances of each class.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataMultiTrack.h 4df997b 
>   src/lib/marble/geodata/data/GeoDataMultiTrack.cpp 6b8d940 
>   src/lib/marble/geodata/data/GeoDataTrack.h e147e6f 
>   src/lib/marble/geodata/data/GeoDataTrack.cpp 955db57 
>   tests/TestEquality.cpp bf4ee53 
> 
> Diff: https://git.reviewboard.kde.org/r/117416/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140425/a56d962e/attachment.html>