[Marble-devel] Review Request 117390: Added more installed header files and tried to reduce exposition of cloudsync headers

[Philippe Renon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117390/
-----------------------------------------------------------

(Updated April 9, 2014, 11:53 p.m.)


Review request for Marble.


Changes
-------

This patch builds on top of the following fixes:
- https://projects.kde.org/projects/kde/kdeedu/marble/repository/revisions/087097b10911914ebad1648775f282cfdbc60bb5
- https://projects.kde.org/projects/kde/kdeedu/marble/repository/revisions/ca4176ddbe94917a13658dd8467c80abd7a2e74c

It is now not necessary anymore to include cloudsync/CloudSyncManager when using QtMarbleConfigDialog.
No cloudsync headers are installed.

This patch also adds MarbleLocale.h to the installed headers as it is now required by QtMarbleConfigDialog.


Repository: marble


Description
-------

This patch adds more installed headers files.
It addresses the issues described here : http://forum.kde.org/viewtopic.php?f=217&t=120442

I have tried to remove some cloudsync/*.h includes to avoid exposing them.
I did this by forward declaring cloudsync classes in a few places.

Unfortunately, in one critical file, namely QtMarbleConfigDialog, it was not possible to forward declare a cloudsync class.
And this because, a method was added that references a cloudsync enum and enums cannot be forward declared (at least with with current C++ version).


Diffs (updated)
-----

  src/apps/marble-qt/QtMainWindow.cpp 221cbc7 
  src/apps/marble-ui/ControlView.cpp cf69c5e 
  src/lib/marble/CMakeLists.txt bb6f312 
  src/lib/marble/QtMarbleConfigDialog.h 1354576 
  src/lib/marble/QtMarbleConfigDialog.cpp 482c7a9 
  src/lib/marble/cloudsync/CloudSyncManager.h 3a0351a 
  src/lib/marble/cloudsync/CloudSyncManager.cpp c644bb6 
  src/lib/marble/cloudsync/RouteSyncManager.h 46e9526 
  src/lib/marble/cloudsync/RouteSyncManager.cpp 4f0631b 

Diff: https://git.reviewboard.kde.org/r/117390/diff/


Testing
-------


Thanks,

Philippe Renon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140409/69c1a113/attachment.html>