[Marble-devel] Review Request 117459: Bug 332260 - Fix and extend handling the KML extrude tag

[Marek Hakala]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117459/
-----------------------------------------------------------

(Updated April 9, 2014, 8:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for Marble and Dennis Nienhüser.


Bugs: 332260
    http://bugs.kde.org/show_bug.cgi?id=332260


Repository: marble


Description
-------

This task is about implementing full support for the KML extrude tag. It can occur as a child element of <Point>, <Polygon>, <LineString> and <LinearRing>. See https://developers.google.com/kml/documentation/kmlreference for details.
- Fix KmlextrudeTagHandler::parse, which does a faulty boolean check if( parentItem.nodeAs<GeoDataGeometry>() ). Change both checks in that area to use
parentItem.is<GeoData...>() for all fours elements (GeoDataPoint, GeoDataLineString, GeoDataLinearRing, GeoDataPolygon). Assign them the extrude value as necessary.
- Extend all Kml*TagWriter.cpp files for Point, LineString, LinearRing and Polygon to write the extrude tag if extrude is active (so either <extrude>1</extrude> ends up in the KML file or nothing).
- Extend the .kml files in tests/data/ to have at least one instance with <extrude>1</extrude> for all four tags


I fixed the reading procedure of extrude tag and extended the tests data for extrude tag. I think that the solution satisfies the task.


Diffs
-----

  src/lib/marble/geodata/handlers/kml/KmlExtrudeTagHandler.cpp 53f1668 
  src/lib/marble/geodata/writers/kml/KmlLineStringTagWriter.cpp 6b21990 
  src/lib/marble/geodata/writers/kml/KmlLinearRingTagWriter.cpp 011fff7 
  src/lib/marble/geodata/writers/kml/KmlPointTagWriter.cpp ebdfecd 
  src/lib/marble/geodata/writers/kml/KmlPolygonTagWriter.cpp d190812 
  tests/data/Geometries.kml 30bfe1b 

Diff: https://git.reviewboard.kde.org/r/117459/diff/


Testing
-------


Thanks,

Marek Hakala

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140409/7a1018c0/attachment.html>