[Marble-devel] Review Request 117408: Bug 333117 - Equality operators for time related classes

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117408/#review55307
-----------------------------------------------------------


This review has been submitted with commit c40b1bd55a459491a35ebe382d7f1ab4f8d99a17 by Dennis Nienhüser on behalf of Cruceru Calin-Cristian to branch master.

- Commit Hook


On April 6, 2014, 10:54 p.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117408/
> -----------------------------------------------------------
> 
> (Updated April 6, 2014, 10:54 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 333117
>     http://bugs.kde.org/show_bug.cgi?id=333117
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added operator== and operator!= to the classes GeoDataTimeSpan and GeoDataTimeStamp. 
> Changed the protected bool equals method of GeoDataObject to become virtual, and overwrote it in GeoDataAbstractView. 
> Made sure that TestEquality still succeeds. 
> Extended TestEquality by a new unit test method for GeoDataTimeSpan and GeoDataTimeStamp.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataAbstractView.h 820354b 
>   src/lib/marble/geodata/data/GeoDataAbstractView.cpp 1c00395 
>   src/lib/marble/geodata/data/GeoDataGeometry.h cf2c66f 
>   src/lib/marble/geodata/data/GeoDataGeometry.cpp 094e9aa 
>   src/lib/marble/geodata/data/GeoDataObject.h b7869d4 
>   src/lib/marble/geodata/data/GeoDataPoint.cpp 20fd44b 
>   src/lib/marble/geodata/data/GeoDataTimeSpan.h bc019fc 
>   src/lib/marble/geodata/data/GeoDataTimeSpan.cpp 4f1fbae 
>   src/lib/marble/geodata/data/GeoDataTimeStamp.h da281b1 
>   src/lib/marble/geodata/data/GeoDataTimeStamp.cpp e65539a 
>   tests/TestEquality.cpp bf4ee53 
> 
> Diff: https://git.reviewboard.kde.org/r/117408/diff/
> 
> 
> Testing
> -------
> 
> The tests are within TestEquality.cpp. I also checked the GeoDataObject::equals() functionality.
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140409/434772ad/attachment-0001.html>