[Marble-devel] Review Request 117438: Added equality operator for style related classes

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117438/#review55305
-----------------------------------------------------------

Ship it!


Thanks, looks good :)

- Dennis Nienhüser


On April 8, 2014, 4:38 p.m., Abhinav Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117438/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 4:38 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 333118
>     http://bugs.kde.org/show_bug.cgi?id=333118
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> 1. Equality Operator for style related classes.
> 2. Added unit tests in TestEquality class to test the equality operator that have been implemented.
> 3. Changed TestEquality::itemIconTest() to initialize the contents of images( img1, img2 ) using 'QImage::fill( Qt::GlobalColor color )' so that 
>    'QImage::operator==()' is able to compare images for equality. Initializing width, height and format only and keeping these parameters same for two images 
>    isn't sufficient to make the images equal. As a result, the 'QImage::operator==()' always returns false.
> 4. Changed TestGeoDataCopy::copyStyleMap() so that both styleMap and testMap are of GeoDataStyleMap type object.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataIconStyle.h 9a4abbf 
>   src/lib/marble/geodata/data/GeoDataIconStyle.cpp b8310cf 
>   src/lib/marble/geodata/data/GeoDataLabelStyle.h bc161a8 
>   src/lib/marble/geodata/data/GeoDataLabelStyle.cpp 8b77188 
>   src/lib/marble/geodata/data/GeoDataLineStyle.h 6063c74 
>   src/lib/marble/geodata/data/GeoDataLineStyle.cpp 2518ab8 
>   src/lib/marble/geodata/data/GeoDataListStyle.h 3d84a23 
>   src/lib/marble/geodata/data/GeoDataListStyle.cpp 7418845 
>   src/lib/marble/geodata/data/GeoDataPolyStyle.h 2fe9886 
>   src/lib/marble/geodata/data/GeoDataPolyStyle.cpp 226372e 
>   src/lib/marble/geodata/data/GeoDataStyle.h 2e4ccde 
>   src/lib/marble/geodata/data/GeoDataStyle.cpp da85e2d 
>   src/lib/marble/geodata/data/GeoDataStyleMap.h b81c653 
>   src/lib/marble/geodata/data/GeoDataStyleMap.cpp 2e7313a 
>   src/lib/marble/geodata/data/GeoDataStyleSelector.h bf4d7ab 
>   src/lib/marble/geodata/data/GeoDataStyleSelector.cpp 644158b 
>   tests/TestEquality.cpp bf4ee53 
>   tests/TestGeoDataCopy.cpp ab938b7 
> 
> Diff: https://git.reviewboard.kde.org/r/117438/diff/
> 
> 
> Testing
> -------
> 
> All tests pass on running TestEquality.
> 
> 
> Thanks,
> 
> Abhinav Gangwar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140409/997b7479/attachment.html>