[Marble-devel] Review Request 117362: Qt 5.2.1 introduced compatibility breaking changes in QUrl

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117362/#review55052
-----------------------------------------------------------


This review has been submitted with commit 563334b6578fac4cc6fb27f7893acef952f074de by Dennis Nienhüser on behalf of Philippe Renon to branch master.

- Commit Hook


On April 3, 2014, 8:40 p.m., Philippe Renon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117362/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 8:40 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Qt5.2.1 introduced changes to QUrl that breaks detokenizing of some URLs.
> Some methods like QUrl::toString() now return encoded strings that were previously returned decoded.
> In particular URL that contain tokens like {x} would be returned as %7Bx%7D
> 
> The proposed fix has been tested with Qt 5.2.1 and 5.1.1 both under Windows and Linux.
> 
> When compiling with Qt 4 the code is left unchanged.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/ServerLayout.cpp 3b8233e 
> 
> Diff: https://git.reviewboard.kde.org/r/117362/diff/
> 
> 
> Testing
> -------
> 
> Qt 5.2.1 and 5.1.1 both under Windows and Linux
> 
> 
> Thanks,
> 
> Philippe Renon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140406/985ee534/attachment.html>