[Marble-devel] Review Request 117343: Bug 332259 - Add a KML tag writer for NetworkLinkControl

[Marek Hakala]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117343/
-----------------------------------------------------------

Review request for Marble and Dennis Nienhüser.


Bugs: 332259
    http://bugs.kde.org/show_bug.cgi?id=332259


Repository: marble


Description
-------

Marble has KML tag handlers to parse <NetworkLinkControl> and related child tags, which are represented in a GeoDataNetworkLinkControl. Add a KML tag writer for <NetworkLinkControl> to write back the values.
- Add KmlNetworkLinkControlTagWriter.{h,cpp} to src/lib/marble/geodata/writers/kml/, implement it and add it to CMakeLists.txt in src/lib/marble/geodata/
- Add NetworkLinkControl.kml to tests/data/

See https://developers.google.com/kml/documentation/kmlreference?#networklinkcontrol for reference and examples.

Make sure to compile Marble with the following cmake options enabled: BUILD_MARBLE_TESTS=TRUE, BUILD_MARBLE_TOOLS=TRUE. Execute tests/TestGeoDataWriter and make sure no errors come up. Use tools/kml2kml to analyze errors and fix the tag writers, if needed. Submit a review request at https://git.reviewboard.kde.org with the marble group as reviewers.

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.
-----------------------------------------------------------------------------------------

List of changes:
- I added class files for NetworkLinkControl writer ( KmlNetworkLinkControlTagWriter.{cpp,h} )
- I added class files for Update writer ( KmlUpdateTagWriter.{cpp,h} )
- I added testdata file for NetworkLinkControl tag ( KML file )
- I fixed the handler for reading the NetworkLinkControl and LinkSnippet tags ( KmlNetworkLinkControlTagHandler.cpp and KmlLinkSnippetTagHandler.cpp )


Diffs
-----

  tests/data/NetworkLinkControl.kml PRE-CREATION 
  src/lib/marble/geodata/CMakeLists.txt 69edb65 
  src/lib/marble/geodata/handlers/kml/KmlLinkSnippetTagHandler.cpp 4844490 
  src/lib/marble/geodata/handlers/kml/KmlNetworkLinkControlTagHandler.cpp 3b320bb 
  src/lib/marble/geodata/writers/kml/KmlNetworkLinkControlTagWriter.h PRE-CREATION 
  src/lib/marble/geodata/writers/kml/KmlNetworkLinkControlTagWriter.cpp PRE-CREATION 
  src/lib/marble/geodata/writers/kml/KmlUpdateTagWriter.h PRE-CREATION 
  src/lib/marble/geodata/writers/kml/KmlUpdateTagWriter.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117343/diff/


Testing
-------


Thanks,

Marek Hakala

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140402/0547c888/attachment.html>