[Marble-devel] Review Request 112908: Merge Qt Components plugin into Marble Touch

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112908/
-----------------------------------------------------------

(Updated Sept. 24, 2013, 8:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for Marble.


Description
-------

The philosophy behind QML is to allow writing new components in few lines of code.
In addition, I'd like to see 3rd parties to come up with their own UI ideas.
Therefore, let's make the components non-reusable by merging them into Marble Touch.


Diffs
-----

  src/plugins/CMakeLists.txt 22ec982d43e360eacccebbcce87e0e4b5a408bb6 
  src/plugins/qt-components/CMakeLists.txt e2db1bfa6c5a085f16526e3150b5e3bef2a2f389 
  src/plugins/qt-components/FileDialog.qml  
  src/plugins/qt-components/FileOpenDialog.qml 3e2143ef330d2319f3546cb4e98a6e29802c052a 
  src/plugins/qt-components/FileSaveDialog.qml 884273b2e4fa6fcccf0fe3d2d050f43f67d24d34 
  src/plugins/qt-components/PlacemarkEditor.qml  
  src/plugins/qt-components/QtComponentsPlugin.h f1f95f007bb416200327bd5c7a429f9e95527fde 
  src/plugins/qt-components/QtComponentsPlugin.cpp 1b3f9c9921c9160623b9e1c525864a6b37be7d4f 
  src/plugins/qt-components/RouteEditor.qml  
  src/plugins/qt-components/SearchField.qml e52077ad79960702d928861ce76176a9e7e91e7f 
  src/plugins/qt-components/ViaPointEditor.qml  
  src/plugins/qt-components/harmattan/MarbleMenuLayout.qml  
  src/plugins/qt-components/harmattan/MarbleToolIcon.qml  
  src/plugins/qt-components/harmattan/MenuItemSwitch.qml  
  src/plugins/qt-components/marker-direction.svg  
  src/plugins/qt-components/marker-yellow.svg  
  src/plugins/qt-components/marker.svg  
  src/plugins/qt-components/placemark.svg  
  src/plugins/qt-components/plasma/MarbleMenuLayout.qml  
  src/plugins/qt-components/plasma/MarbleToolIcon.qml  
  src/plugins/qt-components/plasma/MenuItemSwitch.qml  
  src/plugins/qt-components/qmldir 40cab8f4bd73256d944b900175247c67f8e511a2 
  src/plugins/qt-components/qtcomponents.qrc eca7c20c812e9c65843e54090fe93f8233ad423c 
  src/qt-components/marble-touch/AboutMarblePage.qml 72f42e4cb49ee460264b3b8e9be0a82f0bba553c 
  src/qt-components/marble-touch/CMakeLists.txt 374b1c6c18fb0eb4c5aebd1e175fca6b3837cbf4 
  src/qt-components/marble-touch/CloudSyncPage.qml d019695ce7c70066ef4c8c881a74c834e4131e0b 
  src/qt-components/marble-touch/MainWidget.qml 844dc0b9fc338174a0a4ad2101b9f53e07bb8ca1 
  src/qt-components/marble-touch/MapThemePage.qml ae8b078b220588af483d482525d0e980911fe9f3 
  src/qt-components/marble-touch/MapThemeSelectionPage.qml 55e2da5f90fc4fba45353a25f40c23af1935881c 
  src/qt-components/marble-touch/OfflineDataPage.qml 2c04038b59f5c62ef58877a44dfe74a99d1f2a67 
  src/qt-components/marble-touch/PositionIndicator.qml 2f210117715f7f646d0879710885a34dd1f7db5c 
  src/qt-components/marble-touch/PreferencesPage.qml b838d7edf91875d524c54d2994b36a1daa86cd87 
  src/qt-components/marble-touch/activities/Explore.qml 604ca6609d4e51ace296b4e3aec3f958ac4312c1 
  src/qt-components/marble-touch/activities/Friends.qml 0b08478d6bdb7924b2b45dc269c4fc194a5afce5 
  src/qt-components/marble-touch/activities/Geocaching.qml 48c14fa0abe6bcb6e466cf298e913b7fbaf394fa 
  src/qt-components/marble-touch/activities/Navigation.qml 47bd3694d6ce17aa8aa58b5482530838d7bc7f5f 
  src/qt-components/marble-touch/activities/Placemark.qml e1316d2085f0e68e8a08b0ead0da7204ba5f2782 
  src/qt-components/marble-touch/activities/Routing.qml 73e325f581b298fbd2a36cf1ef5bc546db823181 
  src/qt-components/marble-touch/activities/Search.qml 31e150905b59673b75b08d87ff2c7f8483ae88bb 
  src/qt-components/marble-touch/activities/SpaceView.qml aee54823c32c51c5fbc7a9c02f7005e99b84c1e1 
  src/qt-components/marble-touch/activities/Tracking.qml 5954f05386863b1beb50266399fb8d3cfb3263d4 
  src/qt-components/marble-touch/activities/VirtualGlobe.qml 7eb6cd1d91695b85f21345d0f0cc2e3bb2576561 
  src/qt-components/marble-touch/activities/Weather.qml 623a685b7e9e1805b2e6bcca8ad2e206819dbf7c 
  src/qt-components/marble-touch/harmattan/MarbleWindow.qml ec55b8fc8a256ccf7bc712dff4e9a54acc56b7cd 
  src/qt-components/marble-touch/harmattan/harmattan.qrc PRE-CREATION 
  src/qt-components/marble-touch/meego.qrc a9e3bf70762fa3323feabbea73d3226eaebaa154 
  src/qt-components/marble-touch/plasma/MarbleWindow.qml aaca0be1698a40f876c1b34edbcc51a4294fd1e0 
  src/qt-components/marble-touch/plasma/plasma.qrc PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112908/diff/


Testing
-------


Thanks,

Bernhard Beschow

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130924/c45e8ca4/attachment-0001.html>