[Marble-devel] Review Request 112735: Cloud synchronization for routes in Marble Touch

Dennis Nienhüser earthwings at gentoo.org
Sun Sep 15 14:47:58 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112735/#review40068
-----------------------------------------------------------

Ship it!


Nice work, thanks :-)


src/qt-components/marble-touch/activities/Routing.qml
<http://git.reviewboard.kde.org/r/112735/#comment29652>

    Please set anchors or width such that text wrapping happens. Currently it has no width constraint and therefore stays in one line, overflowing the image.


- Dennis Nienhüser


On Sept. 15, 2013, 10:39 a.m., Andrei Duma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112735/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2013, 10:39 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Added an entry for cloud sync in Preferences.
> Also, a menu entry in the Routing activity, which brings up a management pane for routes.
> 
> 
> Diffs
> -----
> 
>   src/plugins/declarative/MarbleSettings.qml 1e6064d 
>   src/qt-components/marble-touch/CloudSyncPage.qml PRE-CREATION 
>   src/qt-components/marble-touch/MainWidget.qml d78b2e8 
>   src/qt-components/marble-touch/PreferencesPage.qml aaf610e 
>   src/qt-components/marble-touch/activities/Routing.qml 68f0e19 
>   src/qt-components/marble-touch/harmattan/MarbleWindow.qml f7c7846 
>   src/qt-components/marble-touch/meego.qrc 31fd99f 
> 
> Diff: http://git.reviewboard.kde.org/r/112735/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Duma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130915/0eb69e13/attachment.html>


More information about the Marble-devel mailing list