[Marble-devel] Review Request 112454: GroundOverlay Editing

Adrian Draghici draghici.adrian.b at gmail.com
Mon Sep 2 16:24:49 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112454/
-----------------------------------------------------------

Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.


Description
-------

This patch adds basic editing possibilities for ground overlays, such as:
- editing an overlay by clicking on it on the globe
- adding an overlay by using the add button in the annotate toolbar
- removing an overlay using the remove button in the annotate toolbar

I did not encapsulate the GeoDataGroundOverlays in a GroundOverlayGraphicsItem as I thought it was not necessary. This is a temporary patch and I'm looking forward to suggestions.

Features to come:
- live resizing of overlays
- live dragging


Diffs
-----

  src/lib/MarbleMap.h 7019bfa 
  src/lib/MarbleMap.cpp 4d07a4a 
  src/lib/MarbleWidget.h 6493a6c 
  src/lib/MarbleWidget.cpp 026d996 
  src/lib/layers/TextureLayer.h cabcd99 
  src/marble.qrc 753bf24 
  src/plugins/render/annotate/AnnotatePlugin.h 41ad2cb 
  src/plugins/render/annotate/AnnotatePlugin.cpp c6ff1bb 
  src/plugins/render/annotate/CMakeLists.txt d6097e2 
  src/plugins/render/annotate/EditGroundOverlayDialog.h e69de29 
  src/plugins/render/annotate/EditGroundOverlayDialog.cpp e69de29 
  src/plugins/render/annotate/EditGroundOverlayDialog.ui e69de29 

Diff: http://git.reviewboard.kde.org/r/112454/diff/


Testing
-------

Manually tested with various overlays.


Thanks,

Adrian Draghici

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130902/dabc4ced/attachment.html>


More information about the Marble-devel mailing list