[Marble-devel] Review Request 114167: Notify the user if anything goes wrong during bookmark synchronization

[Utku Aydın]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114167/#review44843
-----------------------------------------------------------



src/lib/marble/cloudsync/BookmarkSyncManager.cpp
<http://git.reviewboard.kde.org/r/114167/#comment32054>

    This breaks bookmark synchronization. Exceptionally, in this case, if the API request is sucessful, the response is in KML format not JSON. Only error responses are in JSON format.
    
    Also QString "response" is always empty because m_downloadReply->readAll() has been called before, the first call purges all the data. You should use QByteArray result.


- Utku Aydın


On Nov. 29, 2013, 7:14 p.m., Oskar Jauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114167/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 7:14 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Notifies the user if anything goes wrong during bookmark synchronization.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-kde/marble_part.cpp 082ad5e 
>   src/apps/marble-qt/QtMainWindow.h 80ae250 
>   src/apps/marble-qt/QtMainWindow.cpp a713272 
>   src/apps/marble-ui/ControlView.h 8fc3dfb 
>   src/apps/marble-ui/ControlView.cpp 74a7ba3 
>   src/lib/marble/cloudsync/BookmarkSyncManager.h 8bb2ae5 
>   src/lib/marble/cloudsync/BookmarkSyncManager.cpp 26c4c7a 
> 
> Diff: http://git.reviewboard.kde.org/r/114167/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oskar Jauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131129/e46f1616/attachment.html>