[Marble-devel] Review Request 114204: ADDED THE FEATURE OF CHECKBOX-STATE DEPENDENT DESCRIPTIONS TO MAP THEMES

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114204/#review44805
-----------------------------------------------------------


What solution would I use if there are multiple elements which should change?

What if I wanted to have the text change on marking a checkbox or a radiobutton? 

I  was rather thinking of a javascript-only solution when I created this task ... 

- Torsten Rahn


On Nov. 29, 2013, 2:41 p.m., Yazeed Zoabi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114204/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 2:41 p.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> For each checked checkbox or radio button or selected comboBox option, a paragraph describing it can be added now, when it's selected It shows up, when it's not, it disappears :D
> 
> a simple change a map maker should do, in the legend.html file, is to add the paragraph. :D with it's ID set to the 'connect' attribute of the section in the dgml file. example: 
> 
> 
> <p id="hevelius" style="display:none;">Hevelius' telescope could see much more detail than could previous telescopes. He saw mountains on the Moon, for example, and was able to estimate their heights. With his skill at drawing and his attention to detail, he created extremely intricate maps.</p>
> 
> <p id="riciolli" style="display:none;">Riccioli (Giovanni Battista Riccioli) first published his map of the moon in Almagestum nouum, published in Bologna in 1651. The Riccioli moon map is historically of great importance, as it provides the basis for the system of lunar nomenclature still in use.</p>
> 
> these were added to the legend.html file, and the ids riciolli and hevelius are the values of the 'connect' attribute in the sections of the dgml file: 
> 
> 	      <section name="riciolli" checkable="true" radio="Ric_Hev" connect="riciolli" spacing="12">
> 		  <heading>Riciolli</heading>
> 	      </section>
> 	      <section name="hevelius" checkable="true" radio="Ric_Hev" connect="hevelius" spacing="12">
> 		  <heading>Hevelius</heading>
> 	      </section>
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleLegendBrowser.h e7fb4b5 
>   src/lib/marble/MarbleLegendBrowser.cpp 644dd0f 
>   src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h d426e0d 
>   src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp 20b0ebe 
>   src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp 66ee562 
>   src/lib/marble/geodata/scene/GeoSceneSection.h 5224f43 
>   src/lib/marble/geodata/scene/GeoSceneSection.cpp 9d7bf77 
> 
> Diff: http://git.reviewboard.kde.org/r/114204/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> new map
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/11/29/8e06db64-4f68-49a7-b259-2619799c708c__doppelmayr1707.zip
> 
> 
> Thanks,
> 
> Yazeed Zoabi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131129/d78e64f9/attachment-0001.html>