[Marble-devel] Review Request 114144: Fixed / Improved default selection of checkboxes, radio buttons, comboboxes in Marble Legend Browser

[Yazeed Zoabi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114144/
-----------------------------------------------------------

(Updated Nov. 28, 2013, 8:45 p.m.)


Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.


Repository: marble


Description
-------

The selection of checkboxes, radio buttons and comboBoxes now gets saved with this diff. (Selection gets saved when the user even restarts Marble).
This depends on a previous review that did not got committed (the combobox support, the comments suggested by Torsten Rahn were fixed in THIS diff).
comboBox review : https://git.reviewboard.kde.org/r/114082/ 

gci task: http://www.google-melange.com/gci/task/view/google/gci2013/5847900902916096


Diffs (updated)
-----

  src/lib/marble/MarbleLegendBrowser.h e7fb4b5 
  src/lib/marble/MarbleLegendBrowser.cpp 644dd0f 
  src/lib/marble/geodata/handlers/DgmlOptionTagHandler.h e69de29 
  src/lib/marble/geodata/handlers/DgmlOptionTagHandler.cpp e69de29 
  src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h d426e0d 
  src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp 20b0ebe 
  src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp 66ee562 
  src/lib/marble/geodata/scene/GeoSceneOption.h e69de29 
  src/lib/marble/geodata/scene/GeoSceneOption.cpp e69de29 
  src/lib/marble/geodata/scene/GeoSceneSection.h 5224f43 
  src/lib/marble/geodata/scene/GeoSceneSection.cpp 9d7bf77 

Diff: http://git.reviewboard.kde.org/r/114144/diff/


Testing
-------


Thanks,

Yazeed Zoabi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131128/901b1cc8/attachment.html>