[Marble-devel] Review Request 114167: Notify the user if anything goes wrong during bookmark synchronization

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114167/#review44622
-----------------------------------------------------------


Looks great. I like that you're using private slots and relay the actual error message to the user.


src/apps/marble-kde/marble_part.h
<http://git.reviewboard.kde.org/r/114167/#comment31841>

    showErrorMsg => showErrorMessage (no abbreviations)
    +const (=> const QString &error)



src/apps/marble-kde/marble_part.cpp
<http://git.reviewboard.kde.org/r/114167/#comment31842>

    QString& => QString



src/apps/marble-kde/marble_part.cpp
<http://git.reviewboard.kde.org/r/114167/#comment31843>

    QString& => QString



src/apps/marble-kde/marble_part.cpp
<http://git.reviewboard.kde.org/r/114167/#comment31844>

    Can't we move this method to ControlView? Then it is shared among marble-qt and marble-kde automatically



src/apps/marble-qt/QtMainWindow.h
<http://git.reviewboard.kde.org/r/114167/#comment31845>

    See above, would rather have it in ControlView



src/apps/marble-qt/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/114167/#comment31846>

    Can be done in ControlView when moving the error message there (ControlView is a GUI class as well, so it's ok there)



src/apps/marble-qt/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/114167/#comment31847>

    QString& => const QString &



src/lib/marble/cloudsync/BookmarkSyncManager.h
<http://git.reviewboard.kde.org/r/114167/#comment31848>

    QString& => const QString&


- Dennis Nienhüser


On Nov. 27, 2013, 8:38 p.m., Oskar Jauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114167/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2013, 8:38 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Notifies the user if anything goes wrong during bookmark synchronization.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-kde/marble_part.h ddb91ea 
>   src/apps/marble-kde/marble_part.cpp 082ad5e 
>   src/apps/marble-qt/QtMainWindow.h 80ae250 
>   src/apps/marble-qt/QtMainWindow.cpp a713272 
>   src/lib/marble/cloudsync/BookmarkSyncManager.h 8bb2ae5 
>   src/lib/marble/cloudsync/BookmarkSyncManager.cpp 26c4c7a 
> 
> Diff: http://git.reviewboard.kde.org/r/114167/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oskar Jauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131127/9b3a6430/attachment-0001.html>