[Marble-devel] Review Request 114089: [GCI] kwallet support for owncloud sync

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114089/#review44621
-----------------------------------------------------------



src/apps/marble-kde/marble_part.h
<http://git.reviewboard.kde.org/r/114089/#comment31839>

    Should be initialized to 0 in the constructor



src/apps/marble-kde/marble_part.cpp
<http://git.reviewboard.kde.org/r/114089/#comment31838>

    This member variable is only used in one method, so it can be a local variable in that method as well.



src/apps/marble-kde/marble_part.cpp
<http://git.reviewboard.kde.org/r/114089/#comment31840>

    "So, do you" => "Do you"


- Dennis Nienhüser


On Nov. 25, 2013, 2:25 p.m., Egor Matirov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114089/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 2:25 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> kwallet support for owncloud sync. GCI task: https://www.google-melange.com/gci/task/view/google/gci2013/5279620895080448
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-kde/marble.kcfg dd6b199 
>   src/apps/marble-kde/marble_part.h ddb91ea 
>   src/apps/marble-kde/marble_part.cpp 082ad5e 
> 
> Diff: http://git.reviewboard.kde.org/r/114089/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screensot of dialog - 1
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/e37786c6-e63c-4138-82ac-0e5b245698b2__Marble-KWallet1.png
> Screenshot of dialog - 2
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/34170a72-02cc-48c1-a0c4-27703788e99f__Marble-KWallet2.png
> Screenshot of dialog - 3
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/96a3406f-a57f-441e-8d65-b12f9f028c5b__Marble-KWallet3.png
> 
> 
> Thanks,
> 
> Egor Matirov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131127/45ec4837/attachment.html>